Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BLE RX filter options #2236

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Conversation

Donny-Guo
Copy link
Contributor

I'm proposing adding a filter option for BLE RX app. User can choose to look for keyword either in the data string or MAC address, per comments from #1625.

Filter option: Data, MAC

@htotoo htotoo requested a review from iNetro September 5, 2024 10:45
@zxkmm
Copy link
Contributor

zxkmm commented Sep 5, 2024

Thank you! Please fix syntax format, thank you!

 firmware/application/apps/ble_rx_app.hpp:189:34: error: code should be clang-formatted [-Wclang-format-violations]
    void paint(Painter&) override {};
                                 ^

https://github.com/portapack-mayhem/mayhem-firmware/wiki/Code-formatting

Copy link
Member

@gullradriel gullradriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, many thanks !

@gullradriel gullradriel merged commit 76763b9 into portapack-mayhem:next Sep 6, 2024
3 checks passed
@Donny-Guo Donny-Guo deleted the donny_ble_rx branch September 6, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants